fix: json bug on struct input #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pianist038801 <[email protected]>
govalt
reviewed
Oct 20, 2021
kumare3
previously approved these changes
Oct 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage ? 63.59%
=========================================
Files ? 364
Lines ? 7879
Branches ? 1378
=========================================
Hits ? 5011
Misses ? 2868
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Pianist038801 <[email protected]>
jsonporter
approved these changes
Oct 25, 2021
flyte-bot
added a commit
that referenced
this pull request
Oct 25, 2021
## [0.29.2](http://github.com/lyft/flyteconsole/compare/v0.29.1...v0.29.2) (2021-10-25) ### Bug Fixes * json bug on struct input ([#233](http://github.com/lyft/flyteconsole/issues/233)) ([88c23a6](http://github.com/lyft/flyteconsole/commit/88c23a6ee9f598c9cf31f1999cf6a9c712d8d6e0))
|
🎉 This PR is included in version 0.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pianist038801 [email protected]
This fixes the bug occurring when launching workflow with JSON schema.
Type
Are all requirements met?
fixes flyteorg/flyte#1718
Follow-up issue
NA