feat: Launch Form Msgpack IDL Supporting #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyonlu13
force-pushed
the
msgpack-idl-supporting
branch
from
0b77db6
to
67ba812
Compare
ursucarina
requested changes
Oct 15, 2024
packages/oss-console/src/components/Launch/LaunchForm/LaunchFormComponents/StructInput.tsx
Outdated
Show resolved
Hide resolved
ursucarina
previously approved these changes
Oct 16, 2024
Signed-off-by: Lyon Lu <[email protected]>
Signed-off-by: Lyon Lu <[email protected]>
Signed-off-by: Lyon Lu <[email protected]>
lyonlu13
force-pushed
the
msgpack-idl-supporting
branch
from
3c8003d
to
7b873ae
Compare
Signed-off-by: Lyon Lu <[email protected]>
Signed-off-by: Lyon Lu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
changed the title
ursucarina
approved these changes
Oct 17, 2024
|
Congrats on merging your first pull request! 🎉 |
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
eapolinario
reviewed
Oct 17, 2024
| } | ||
|
|
||
| // unsupported binary type, it might be temporary | ||
| return ''; |
There was a problem hiding this comment.
Any reason not to stringify binary.value and return that instead?
ursucarina
added a commit
that referenced
this pull request
Nov 11, 2024
This reverts commit d1dc889.
ursucarina
added a commit
that referenced
this pull request
Nov 12, 2024
* Revert "feat: Launch Form Msgpack IDL Supporting (#888)" This reverts commit d1dc889. * Pre-emptively decode binary literals Signed-off-by: Carina Ursu <[email protected]> * lint fixes Signed-off-by: Carina Ursu <[email protected]> * fix literal.helpers.test.ts Signed-off-by: Carina Ursu <[email protected]> --------- Signed-off-by: Carina Ursu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add msgpack IDL support for the launch form, including input displaying and relaunch input recovering.
Test case: hhttps://localhost.dogfood.cloud-staging.union.ai:8080/console/projects/flytesnacks/domains/development/executions/acj8vfbt8722wg4q46nv
Type