fix: Broken breadcrumbs when using custom BASE_URL

[ddl-rliu]

TL;DR

Typo – causes breadcrumbs to not appear in flyteconsole. To fix, use BASE_URL not BASE_PATH.

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Complete description

Missing breadcrumbs for custom BASE_URL like /custom-base/console

Expectation: breadcrumbs are present for custom BASE_URL Flyte instance.

This happens because when BASE_PATH is used instead of BASE_URL, the logic that generates the breadcrumbs at breadcrumbRegistry.breadcrumbBuilder ends up using the wrong BASE_URL value (this starts from makeUrlSegments). This causes it to parse the window location incorrectly, and the resulting generated breadcrumbs is missing the expected entries.

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

[welcome]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[ddl-rliu]

I believe BASE_PATH may be a typo here, since the process.env object looks like

{
    NODE_ENV: "production",
    ADMIN_API: "//localhost:30080",
    ADMIN_API_URL: "localhost:30080",
    BASE_URL: "/console",
    BASE_HREF: "",
    DISABLE_CONSOLE_ROUTE_PREFIX: "",
    MAINTENANCE_MODE: ""
}

(in the case of a custom path, it looks like ... BASE_URL: "/custom-path/console"

And double checking the repo code, BASE_PATH has no other instance of usage, pointing to this being a potential typo.

[eapolinario]

@jsonporter , can you take a look?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.76%. Comparing base (34edde1) to head (1db296c).

Files	Patch %	Lines
...nsole/src/components/Breadcrumbs/registry/index.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #861   +/-   ##
=======================================
  Coverage   54.76%   54.76%           
=======================================
  Files         578      578           
  Lines       15137    15137           
  Branches     2760     2760           
=======================================
  Hits         8290     8290           
  Misses       6847     6847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ddl-ebrown]

Anything we can do to help get this typo fix merged @eapolinario / @jsonporter ?

[welcome]

Congrats on merging your first pull request! 🎉

[flyte-bot]

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀