fix: invalid item in dropdown #809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
- Coverage 63.39% 63.38% -0.01%
==========================================
Files 527 527
Lines 13391 13393 +2
Branches 2548 2548
==========================================
Hits 8489 8489
- Misses 4902 4904 +2
|
Signed-off-by: Frank Flitton <[email protected]>
|
|
||
| const { | ||
| isLoading, | ||
| error, | ||
| data: popoverQueryData, | ||
| } = useQuery( | ||
| `breadcrumb-list-${props.id}`, | ||
| `breadcrumb-list-${props.id}-${props.value}`, |
There was a problem hiding this comment.
I don't think we should fetch the project list every time the domain changes. I think we should separate the api call and the url generation step so we don't make unnecessary network calls
There was a problem hiding this comment.
This would be a good enhancement, we'd probably need a query hash key, the formatter and data as separate params in the Breadcrumb objects. Some breadcrumbs don't change from url to url etc...
A note here is that it only fetches once the user opens that dropdown.
There was a problem hiding this comment.
This is how the original code worked, not an enhancement. If we separate the list request from the static url generation this wouldn't be a problem
|
|
||
| const { | ||
| isLoading, | ||
| error, | ||
| data: popoverQueryData, | ||
| } = useQuery( | ||
| `breadcrumb-list-${props.id}`, | ||
| `breadcrumb-list-${props.id}-${props.value}`, |
There was a problem hiding this comment.
This is how the original code worked, not an enhancement. If we separate the list request from the static url generation this wouldn't be a problem
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
|
🎉 This PR is included in version 1.9.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Read then delete this section
- Make sure to use a concise title for the pull-request.
- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/