fix: dynamic-node-tasks #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 65.98% 65.92% -0.07%
==========================================
Files 490 490
Lines 11963 11976 +13
Branches 2210 2219 +9
==========================================
+ Hits 7894 7895 +1
- Misses 4069 4081 +12
|
ursucarina
requested review from
a team,
ursucarina,
jsonporter and
james-union
and removed request for
a team
|
This is working well: Verified with the workflow: All fields are populated correctly from the task type and the descriptions are also correct for the task template on the slideout |
Signed-off-by: Soham <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
previously approved these changes
May 23, 2023
Signed-off-by: Soham <[email protected]>
Signed-off-by: Soham <[email protected]>
jsonporter
approved these changes
May 24, 2023
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when viewing children of dynamic task where the various information like the task type/template was not correctly being shown.
Type
Are all requirements met?
Complete description
The issue was caused by incorrectly referencing task definitions from the (root)
compiledWorkflowClosurerather than dynamic execution'sworkflowClosure. The result was that row values like task type as well as information in the execution detail panel (slide-out) were null and showing empty values.fixes #3455
Follow-up issue
NA