From a34dd42b4576d299618c938d6cc4c653a9c93e27 Mon Sep 17 00:00:00 2001 From: Eugene Jahn Date: Fri, 8 Apr 2022 19:31:59 -0700 Subject: [PATCH] fix: fixed the css to avoid overflow and add the duration back to the table --- .../Tables/WorkflowExecutionTable/WorkflowExecutionRow.tsx | 4 +++- .../Executions/Tables/WorkflowExecutionTable/styles.ts | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/Executions/Tables/WorkflowExecutionTable/WorkflowExecutionRow.tsx b/src/components/Executions/Tables/WorkflowExecutionTable/WorkflowExecutionRow.tsx index 3ef77fdf1..ec14ca4a0 100644 --- a/src/components/Executions/Tables/WorkflowExecutionTable/WorkflowExecutionRow.tsx +++ b/src/components/Executions/Tables/WorkflowExecutionTable/WorkflowExecutionRow.tsx @@ -101,7 +101,9 @@ export const WorkflowExecutionRow: React.FC = ({ onCancel: () => setShowConfirmation(false), onConfirmClick: onArchiveConfirmClick, }); - const columnsWithApproval = [...columns.slice(0, -2), confirmation]; + // To hide the onHover action buttons, + // we take off the last column which is onHover actions buttons + const columnsWithApproval = [...columns.slice(0, -1), confirmation]; // we show error info only on active items const { abortMetadata, error } = execution.closure; diff --git a/src/components/Executions/Tables/WorkflowExecutionTable/styles.ts b/src/components/Executions/Tables/WorkflowExecutionTable/styles.ts index 0c1db4d35..11ab0be36 100644 --- a/src/components/Executions/Tables/WorkflowExecutionTable/styles.ts +++ b/src/components/Executions/Tables/WorkflowExecutionTable/styles.ts @@ -34,7 +34,8 @@ export const useStyles = makeStyles((theme: Theme) => ({ }, confirmationButton: { borderRadius: 0, - minWidth: '100px', + // make the button responsive, so the button won't overflow + width: '50%', minHeight: '53px', // cancel margins that are coming from table row style marginTop: theme.spacing(-1),