From 5b368890caf02ca8394432b828cf88db380aa32d Mon Sep 17 00:00:00 2001
From: Carina Ursu <carina@union.ai>
Date: Wed, 3 May 2023 08:55:17 -0700
Subject: [PATCH] chore: guard against /tasks failing (#750)

* chore: guard against /tasks failing

Signed-off-by: Carina Ursu <carina@union.ai>

* chore: pkg

Signed-off-by: Carina Ursu <carina@union.ai>

---------

Signed-off-by: Carina Ursu <carina@union.ai>
---
 packages/console/package.json                        |  2 +-
 .../components/Executions/nodeExecutionQueries.ts    | 12 +++++++++++-
 website/package.json                                 |  2 +-
 yarn.lock                                            |  4 ++--
 4 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/packages/console/package.json b/packages/console/package.json
index 5a654aa30..2bee7a2a1 100644
--- a/packages/console/package.json
+++ b/packages/console/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@flyteorg/console",
-  "version": "0.0.25",
+  "version": "0.0.26",
   "description": "Flyteconsole main app module",
   "main": "./dist/index.js",
   "module": "./lib/index.js",
diff --git a/packages/console/src/components/Executions/nodeExecutionQueries.ts b/packages/console/src/components/Executions/nodeExecutionQueries.ts
index f8aac3622..a768fd246 100644
--- a/packages/console/src/components/Executions/nodeExecutionQueries.ts
+++ b/packages/console/src/components/Executions/nodeExecutionQueries.ts
@@ -27,12 +27,15 @@ import { ignoredNodeIds } from 'models/Node/constants';
 import { isMapTaskV1 } from 'models/Task/utils';
 import { QueryClient } from 'react-query';
 import { getTask } from 'models';
+import { createDebugLogger } from 'common/log';
 import { WorkflowNodeExecution, WorkflowTaskExecution } from './contexts';
 import { fetchTaskExecutionList } from './taskExecutionQueries';
 import { formatRetryAttempt, getGroupedLogs } from './TaskExecutionsList/utils';
 import { NodeExecutionGroup } from './types';
 import { isDynamicNode, isParentNode, nodeExecutionIsTerminal } from './utils';
 
+const debug = createDebugLogger('@nodeExecutionQueries');
+
 function removeSystemNodes(nodeExecutions: NodeExecution[]): NodeExecution[] {
   return nodeExecutions.filter(ne => {
     if (ignoredNodeIds.includes(ne.id.nodeId)) {
@@ -86,7 +89,14 @@ export function makeNodeExecutionAndTasksQuery(
       const taskExecutions = workflowNodeExecution?.taskExecutions || [];
       const taskId = taskExecutions?.[0]?.id?.taskId;
       const compiledTaskClosure = await (taskId
-        ? getTask(taskId!)
+        ? getTask(taskId!).catch(e => {
+            debug(
+              '\t failed to get compiled task closure for taskId: ',
+              taskId,
+              ' Error message:',
+              e,
+            );
+          })
         : Promise.resolve(null));
 
       // step 5: get each task's executions data
diff --git a/website/package.json b/website/package.json
index ca95bd44f..fda9a70d9 100644
--- a/website/package.json
+++ b/website/package.json
@@ -37,7 +37,7 @@
   },
   "dependencies": {
     "@flyteorg/common": "^0.0.4",
-    "@flyteorg/console": "^0.0.25",
+    "@flyteorg/console": "^0.0.26",
     "long": "^4.0.0",
     "protobufjs": "~6.11.3",
     "react-ga4": "^1.4.1",
diff --git a/yarn.lock b/yarn.lock
index 955311d2f..910e383ff 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2020,7 +2020,7 @@ __metadata:
   resolution: "@flyteconsole/client-app@workspace:website"
   dependencies:
     "@flyteorg/common": ^0.0.4
-    "@flyteorg/console": ^0.0.25
+    "@flyteorg/console": ^0.0.26
     "@types/long": ^3.0.32
     long: ^4.0.0
     protobufjs: ~6.11.3
@@ -2059,7 +2059,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@flyteorg/console@^0.0.25, @flyteorg/console@workspace:packages/console":
+"@flyteorg/console@^0.0.26, @flyteorg/console@workspace:packages/console":
   version: 0.0.0-use.local
   resolution: "@flyteorg/console@workspace:packages/console"
   dependencies: