From 27d983800b53084d0985c086753596f2d8f0eec9 Mon Sep 17 00:00:00 2001 From: Nastya Rusina Date: Thu, 7 Apr 2022 18:13:58 -0700 Subject: [PATCH] chore: pr feedback Signed-off-by: Nastya Rusina --- src/components/Entities/EntityDetailsHeader.tsx | 2 +- .../Executions/ExecutionDetails/NodeExecutionTabs/index.tsx | 2 +- .../TaskExecutionsList/MapTaskExecutionListItem.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/Entities/EntityDetailsHeader.tsx b/src/components/Entities/EntityDetailsHeader.tsx index ed9a3375b..ce41b9ce6 100644 --- a/src/components/Entities/EntityDetailsHeader.tsx +++ b/src/components/Entities/EntityDetailsHeader.tsx @@ -24,7 +24,7 @@ const useStyles = makeStyles((theme: Theme) => ({ width: '100%', }, headerText: { - margin: `0 ${theme.spacing(1)}px`, + margin: theme.spacing(0, 1), }, headerTextContainer: { display: 'flex', diff --git a/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx b/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx index 5d11fc937..0ba94c0f3 100644 --- a/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx +++ b/src/components/Executions/ExecutionDetails/NodeExecutionTabs/index.tsx @@ -23,7 +23,7 @@ const useStyles = makeStyles((theme) => { }, }, tabItem: { - margin: `0 ${theme.spacing(1)}px`, + margin: theme.spacing(0, 1), }, }; }); diff --git a/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx b/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx index b701970f6..078d4b680 100644 --- a/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx +++ b/src/components/Executions/TaskExecutionsList/MapTaskExecutionListItem.tsx @@ -35,7 +35,7 @@ interface MapTaskExecutionsListItemProps { showAttempts: boolean; } -const RenderOrder: TaskExecutionPhase[] = [ +const RENDER_ORDER: TaskExecutionPhase[] = [ TaskExecutionPhase.UNDEFINED, TaskExecutionPhase.INITIALIZING, TaskExecutionPhase.WAITING_FOR_RESOURCES, @@ -61,7 +61,7 @@ export const MapTaskExecutionsListItem: React.FC // Set UI elements in a proper rendering order const logsSections: JSX.Element[] = []; - for (const key of RenderOrder) { + for (const key of RENDER_ORDER) { const values = logsInfo.get(key); if (values) { logsSections.push();