diff --git a/.github/config.yml b/.github/config.yml index f99bcd78f..73da252e5 100644 --- a/.github/config.yml +++ b/.github/config.yml @@ -1,8 +1,9 @@ # Comment to be posted on PRs from first-time contributors in your repository -newPRWelcomeComment: > +newPRWelcomeComment: | Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line: + - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: [DCO Guide](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md)). diff --git a/boilerplate/flyte/end2end/end2end.sh b/boilerplate/flyte/end2end/end2end.sh index b28df383f..45877e415 100755 --- a/boilerplate/flyte/end2end/end2end.sh +++ b/boilerplate/flyte/end2end/end2end.sh @@ -18,14 +18,14 @@ pushd ${OUT} if [ ! -z "$IMAGE" ]; then kind load docker-image ${IMAGE} - if [ ${IMAGE_NAME} -eq "flytepropeller" ] + if [ "${IMAGE_NAME}" == "flytepropeller" ] then - sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" ${OUT}/kustomize/base/propeller/deployment.yaml + sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" "${OUT}"/kustomize/base/propeller/deployment.yaml fi - if [ ${IMAGE} -eq "flyteadmin" ] + if [ "${IMAGE_NAME}" == "flyteadmin" ] then - sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" ${OUT}/kustomize/base/admindeployment/deployment.yaml + sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" "${OUT}"/kustomize/base/admindeployment/deployment.yaml fi fi diff --git a/boilerplate/flyte/welcome_bot/config.yml b/boilerplate/flyte/welcome_bot/config.yml index f99bcd78f..73da252e5 100644 --- a/boilerplate/flyte/welcome_bot/config.yml +++ b/boilerplate/flyte/welcome_bot/config.yml @@ -1,8 +1,9 @@ # Comment to be posted on PRs from first-time contributors in your repository -newPRWelcomeComment: > +newPRWelcomeComment: | Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line: + - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: [DCO Guide](https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md)).