Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect original task definition retry strategy for single task executions #5577

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Jul 22, 2024

Why are the changes needed?

It's counter-intuitive that a single task execution doesn't respect a task spec when creating the system-generated workflow but workflow compilation ordinarily does

What changes were proposed in this pull request?

See PR title.

How was this patch tested?

Unit test

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

katrogan added 3 commits July 22, 2024 20:00
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan force-pushed the respect-single-task-retries branch from dbcdfd6 to 3f0d570 Compare July 22, 2024 18:00
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (337088e) to head (3f0d570).
Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
...min/pkg/manager/impl/util/single_task_execution.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5577      +/-   ##
==========================================
- Coverage   60.98%   60.98%   -0.01%     
==========================================
  Files         796      796              
  Lines       51676    51683       +7     
==========================================
+ Hits        31515    31519       +4     
- Misses      17261    17263       +2     
- Partials     2900     2901       +1     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <75.00%> (+<0.01%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.76% <ø> (ø)
unittests-flytepropeller 57.48% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan katrogan merged commit 3082cd3 into master Jul 23, 2024
50 checks passed
@katrogan katrogan deleted the respect-single-task-retries branch July 23, 2024 10:47
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants