Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FlyteDirectory to file_types.rst template #5564

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ppiegaze
Copy link
Member

@ppiegaze ppiegaze commented Jul 16, 2024

Tracking issue

https://linear.app/unionai/issue/DOC-480/fix-rendering-of-flytedirectory-api-doc-page-in-flyte-docs

Why are the changes needed?

FlyteDirectory API docs page is rendering incorrectly

What changes were proposed in this pull request?

Adding FlyteDirectory to the if then logic of the template that produces the rendered page

How was this patch tested?

Local build

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Equivalent in flytekit repo:
flyteorg/flytekit#2584

@ppiegaze ppiegaze requested a review from neverett as a code owner July 16, 2024 15:35
@ppiegaze ppiegaze changed the title Add FlyteDIrectory to file_types.rst template Add FlyteDirectory to file_types.rst template Jul 16, 2024
@ppiegaze ppiegaze requested a review from samhita-alla July 16, 2024 15:37
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (c1563d7) to head (d203cf0).
Report is 116 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5564   +/-   ##
=======================================
  Coverage   60.98%   60.98%           
=======================================
  Files         796      796           
  Lines       51647    51647           
=======================================
  Hits        31497    31497           
  Misses      17250    17250           
  Partials     2900     2900           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 0cddc15 into master Jul 16, 2024
49 of 50 checks passed
@pingsutw pingsutw deleted the peeter/fix-flytedirectory-docs-rendering branch July 16, 2024 18:28
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants