Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Getting Started Navigation Menu #969

Closed
SandraGH5 opened this issue Apr 30, 2021 · 14 comments
Closed

[Docs] Getting Started Navigation Menu #969

SandraGH5 opened this issue Apr 30, 2021 · 14 comments
Labels
documentation Improvements or additions to documentation navigation Improving the user experience when navigating from one section of the docs to another stale untriaged This issues has not yet been looked at by the Maintainers

Comments

@SandraGH5
Copy link
Contributor

https://docs.flyte.org/en/latest/getting_started.html
Getting Started navigates to Concepts -->Basics, even though menu shows the following section to be User Guide. Tutorials is also skipped.

Concepts then navigates to Community (skipping API Reference)

User Guide does not link to a following section - Tutorials is next on the menu.

Tutorials links to User Guide, but this is not shown on the menu.

Concepts --> Basics --> Glossary links to API Reference even though Core Concepts & Architecture are next on the menu.

@SandraGH5 SandraGH5 added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Apr 30, 2021
@kumare3 kumare3 added this to the 0.14.0 milestone May 5, 2021
@kumare3 kumare3 modified the milestones: 0.14.0, 0.15.0 Jun 6, 2021
@EngHabu EngHabu modified the milestones: 0.15.0, 0.16.0 Jul 7, 2021
@EngHabu EngHabu modified the milestones: 0.16.0, 0.17.0 Aug 2, 2021
@EngHabu EngHabu removed this from the 0.17.0 milestone Sep 2, 2021
@SandraGH5
Copy link
Contributor Author

Update:
Getting Started navigates to Concepts (skips User Guide and Tutorials)
API Reference: The main page navigates to Community, but all of the embedded pages are disconnected from the navigation thread (FlyteCTL, FlyteIDL, FlyteKit, etc).
No navigation leads to User Guide.

@SandraGH5 SandraGH5 added the navigation Improving the user experience when navigating from one section of the docs to another label Nov 18, 2021
@yindia yindia self-assigned this Dec 15, 2021
@yindia
Copy link
Contributor

yindia commented Dec 18, 2021

@SandraGH5 Do we need new option in main menu for this page https://docs.flyte.org/en/latest/reference/index.html

@SandraGH5
Copy link
Contributor Author

@evalsocket apologies if I wasn't clear. What I meant is that on the API page, the bottom navigation button under "Next" goes straight to Community, instead of going through Flytectl, Flytekit, Flyteidl, etc.

@yindia
Copy link
Contributor

yindia commented Dec 21, 2021

@SandraGH5 i think community is correct navigation because all these component has there on documentation. If we replace community with flytectl/flyteidl/flytekit then it will redirect us to a detail documentation of these component

cc: @samhita-alla

@samhita-alla
Copy link
Contributor

@SandraGH5 i think community is correct navigation because all these component has there on documentation. If we replace community with flytectl/flyteidl/flytekit then it will redirect us to a detail documentation of these component

cc: @samhita-alla

@evalsocket, Sandra says that the "Next page" links have to be in order. So, APIReference's next page has to be FlyteCTL, FlyteCTL's last page has to point to FlyteIDL, etc. But, @SandraGH5, I think that's not possible because FlyteCTL/FlyteIDL docs are under FlyteCTL and FlyteIDL repositories, respectively, whereas Getting started, API reference, community, etc. are under Flyte repository, and hence "Next page" is always pointing to a page that is in the same repository as that of the current page's repository.

@cosmicBboy, you might have a better idea. What do you think?

@yindia yindia added this to the 0.19.0 - Eagle milestone Dec 22, 2021
@SandraGH5
Copy link
Contributor Author

Thanks for clarifying @samhita-alla.
Is it possible to have the Next button redirect to a hyperlink (e.g. https://docs.flyte.org/projects/flytectl/en/stable/ for Flytectl) since it's not possible to point to a page in a different repo?

@samhita-alla
Copy link
Contributor

I don't think so, @SandraGH5. I tried different techniques, but none is working. :/
We can disable "next page" if it doesn't look right.

@cosmicBboy
Copy link
Contributor

I only solution I can think of is to update the furo theme templates: https://github.com/flyteorg/furo so that we can manually override the links that are auto-generated here: https://github.com/flyteorg/furo/blob/main/src/furo/theme/furo/page.html#L57-L82

We can adapt this approach: readthedocs/sphinx_rtd_theme#921

@cosmicBboy cosmicBboy assigned cosmicBboy and unassigned cosmicBboy Dec 29, 2021
@cosmicBboy
Copy link
Contributor

@evalsocket let me know if you want me to take this on, I'm going to work on some updates to our furo fork anyway

@yindia
Copy link
Contributor

yindia commented Dec 29, 2021

@cosmicBboy sure

@yindia yindia removed their assignment Dec 29, 2021
@cosmicBboy cosmicBboy self-assigned this Jan 3, 2022
@cosmicBboy cosmicBboy removed this from the 0.19.0 - Eagle milestone Jan 3, 2022
@cosmicBboy
Copy link
Contributor

hey @SmritiSatyanV this is the ticket I referred to in standup. Let's chat about it next week!

@cosmicBboy cosmicBboy removed their assignment Jan 14, 2022
@cosmicBboy
Copy link
Contributor

Notes:

@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 18, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation navigation Improving the user experience when navigating from one section of the docs to another stale untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

8 participants