Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] regression: envFrom provided from pod template is discarded #5422

Closed
2 tasks done
flixr opened this issue May 28, 2024 · 1 comment
Closed
2 tasks done

[BUG] regression: envFrom provided from pod template is discarded #5422

flixr opened this issue May 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@flixr
Copy link
Contributor

flixr commented May 28, 2024

Describe the bug

In flyte 1.11 setting a EnvFromSource via pod template works, but this broke with #4969

I have a pod template something like:

primary_container = V1Container(name="primary")
primary_container.env_from = [V1EnvFromSource(secret_ref=V1SecretEnvSource(name="my-secret"))]
ps = V1PodSpec(containers=[primary_container])
pod_template = PodTemplate(pod_spec=ps, primary_container_name="primary")

Expected behavior

The env variables loaded from my-secret are injected into the pod as specified in the pod template.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@flixr flixr added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels May 28, 2024
Copy link

runllm bot commented May 28, 2024

The issue you're describing seems to be related to a regression introduced by a recent pull request. The envFrom provided in the pod template is not being respected in the latest Flyte version. This was working in Flyte 1.11 but broke after the changes in PR #4969.

Would you like more details on how to potentially work around this issue or further steps to debug it?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@eapolinario eapolinario self-assigned this May 30, 2024
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants