You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ArrayNode currently reports events identically to maptask plugin where we encapsulate subNode executions within the ExternalResourceInfo field in TaskExecutionEvent proto message. The ExternalResourceInfo proto message has a phase field, which corresponds to the phase of the subNode. The top-level node phase is reported using (and displayed in the UI from) the NodeExecutionEvent. So there is a task phase on the TaskExecutionEvent that is not currently being used.
However, this phase is incorrect. We attempt to set it on terminal states here , but this code is never reached because terminal states return prematurely. We need to ensure that the phase on the TaskExecutionEvent is correctly set on terminal phases.
Expected behavior
task execution phases match terminal state for array nodes
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
To address the issue of ArrayNode not reporting the terminal state in TaskExecutionEvent, a pull request titled "[Bug] correctly set task execution phase for terminal array node" (PR #5136) is currently open. This PR aims to ensure the correct phase is set in task execution events for terminal ArrayNodes. It is still under review and not yet merged.
Would you like more details on the changes proposed in this pull request?
Describe the bug
ArrayNode currently reports events identically to maptask plugin where we encapsulate subNode executions within the ExternalResourceInfo field in TaskExecutionEvent proto message. The ExternalResourceInfo proto message has a phase field, which corresponds to the phase of the subNode. The top-level node phase is reported using (and displayed in the UI from) the NodeExecutionEvent. So there is a task phase on the TaskExecutionEvent that is not currently being used.
However, this phase is incorrect. We attempt to set it on terminal states here , but this code is never reached because terminal states return prematurely. We need to ensure that the phase on the TaskExecutionEvent is correctly set on terminal phases.
Expected behavior
task execution phases match terminal state for array nodes
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: