-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin helmdocs to 1.12.0 #4995
Pin helmdocs to 1.12.0 #4995
Conversation
Signed-off-by: Eduardo Apolinario <[email protected]>
I recommend visualizing this diff by turning whitespace off: https://github.com/flyteorg/flyte/pull/4995/files?w=1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4995 +/- ##
==========================================
- Coverage 58.97% 58.96% -0.01%
==========================================
Files 645 645
Lines 55562 55562
==========================================
- Hits 32767 32762 -5
- Misses 20200 20205 +5
Partials 2595 2595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this commit locally, and worked well.
LGTM, thanks
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Tracking issue
#4950
Why are the changes needed?
make helm
expects to run on go 1.21, butgithub.com/norwoodj/helm-docs/cmd/helm-docs
recently published a new version where they use go 1.22.What changes were proposed in this pull request?
Pin github.com/norwoodj/helm-docs/cmd/helm-docs to 1.12.0.
How was this patch tested?
Made a change to
flyte-binary
chart and successfully ranmake helm
.Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link