Enable agent service by default #4993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4993 +/- ##
==========================================
+ Coverage 58.98% 59.00% +0.02%
==========================================
Files 645 645
Lines 55548 55551 +3
==========================================
+ Hits 32764 32779 +15
+ Misses 20193 20181 -12
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
EngHabu
previously approved these changes
Mar 6, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
flytepropeller will send error to flyteadmin, and flyteadmin will send error message to flyteconsole. |
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3936
What changes were proposed in this pull request?
Note: This PR only enables the agent-service plugin by default in the helm chart and won't deploy an agent server.
The reason to do that because people won't need to modify the propeller configmap after they install the agent (
helm install flyteagent ...), and also give people with more visibility into flyte agent.How was this patch tested?
Local sandbox
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA