Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update airflow migration #4991

Closed
wants to merge 10 commits into from
Closed

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 1, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

neverett and others added 5 commits February 8, 2024 16:24
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 1, 2024
@pingsutw pingsutw mentioned this pull request Mar 1, 2024
2 tasks
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 62.36559% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (734d82c) to head (bfe3458).

Files Patch % Lines
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 61.53% 27 Missing and 8 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           docs/migration-guides    #4991      +/-   ##
=========================================================
+ Coverage                  58.97%   59.00%   +0.03%     
=========================================================
  Files                        645      645              
  Lines                      55562    55542      -20     
=========================================================
+ Hits                       32768    32774       +6     
+ Misses                     20199    20179      -20     
+ Partials                    2595     2589       -6     
Flag Coverage Δ
unittests 59.00% <62.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change requested, otherwise LGTM, thanks!

@@ -5,6 +5,9 @@
Flyte can compile Airflow tasks into Flyte tasks without changing code, which allows you
to migrate your Airflow DAGs to Flyte with minimal effort.

In addition to migration capabilities, Flyte users can seamlessly integrate Airflow tasks into their workflows, leveraging the ecosystem of Airflow operators and sensors.
By combining the robust Airflow ecosystem with Flyte's capabilities such as caching, versioning, and reproducibility, users can run more complex data and machine learning workflows with ease.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By combining the robust Airflow ecosystem with Flyte's capabilities such as caching, versioning, and reproducibility, users can run more complex data and machine learning workflows with ease.
By combining the robust Airflow ecosystem with Flyte's capabilities such as caching, versioning, and reproducibility, users can run more complex data and machine learning workflows with ease. For more information, see the [Airflow agent documentation](https://docs.flyte.org/en/latest/flytesnacks/examples/airflow_agent/index.html).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated it

@pingsutw pingsutw changed the title update airflow migration [DOC] update airflow migration Mar 4, 2024
@pingsutw pingsutw changed the title [DOC] update airflow migration [DOC] Update airflow migration Mar 4, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 5, 2024
@pingsutw pingsutw marked this pull request as draft March 6, 2024 08:17
Base automatically changed from docs/migration-guides to master March 6, 2024 16:59
@pingsutw pingsutw closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants