Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Use official mockery library for generating mocks #4934

Open
2 tasks done
katrogan opened this issue Feb 22, 2024 · 1 comment
Open
2 tasks done

[Housekeeping] Use official mockery library for generating mocks #4934

katrogan opened this issue Feb 22, 2024 · 1 comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

katrogan commented Feb 22, 2024

Describe the issue

We currently use @EngHabu's 6 year old fork here:
https://github.com/search?q=repo%3Aflyteorg%2Fboilerplate%20enghabu&type=code

although upstream now supports OnFoo method declarations and asserting method called expectations: https://github.com/vektra/mockery

What if we do not do this?

Harder to contribute code for newer contributors and the codebase don't get upstream changes

Related component(s)

testing

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Feb 22, 2024
Copy link

dosubot bot commented Feb 22, 2024

🤖

It's great to see your interest in improving the repository! Using the official mockery library for generating mocks would indeed make it easier for newer contributors to understand and contribute to the codebase. Your proposed solution would be a valuable addition. Thank you for considering this improvement!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

1 participant