[BUG] Do not mount flyte-secret-auth secret if .Values.secrets.adminOauthClientCredentials.enabled is false.

[debajyoti-truefoundry]

Describe the bug

flyte/charts/flyte-core/templates/common/secret-auth.yaml

Line 1 in 1ae5a8f

{{- if .Values.secrets.adminOauthClientCredentials.enabled }}

flyte/charts/flyte-core/templates/flytescheduler/deployment.yaml

Line 96 in 1ae5a8f

secretName: flyte-secret-auth

flyte/charts/flyte-core/templates/propeller/deployment.yaml

Line 103 in 1ae5a8f

secretName: flyte-secret-auth

As you can see in the above links, even though the flyte-secret-auth secret is optionally created, we always mount the corresponding secret in the propeller and the scheduler deployments.

Expected behavior

Explained above.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[dosubot]

🤖

It's great to see you've identified a potential issue and provided context for it. Your understanding of the problem and the proposed solution are valuable contributions to the project. If you're able to propose a fix or create a pull request, it would be a great way to further contribute to the project. Keep up the good work!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[lowc1012]

Hi there, I'd like to take this. Can anyone assign this to me? thanks