Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add monodocs build in flytesnacks CI #4558

Closed
2 tasks done
cosmicBboy opened this issue Dec 8, 2023 · 1 comment · Fixed by flyteorg/flytesnacks#1317
Closed
2 tasks done

[Docs] Add monodocs build in flytesnacks CI #4558

cosmicBboy opened this issue Dec 8, 2023 · 1 comment · Fixed by flyteorg/flytesnacks#1317
Assignees
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation

Comments

@cosmicBboy
Copy link
Contributor

Description

This ticket is to add the monodocs build in the flyte repo as a github actions workflow step to make sure that flytesnacks changes don't break monodocs

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Dec 8, 2023
@cosmicBboy cosmicBboy self-assigned this Dec 8, 2023
@cosmicBboy cosmicBboy added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 8, 2023
Copy link

dosubot bot commented Dec 8, 2023

🤖

Hey @cosmicBboy! 🖖 I'm Dosu, your friendly neighborhood bot. I'm here to help you squash bugs, streamline your contributions, and answer any questions while you wait for a human maintainer. Let's make some code magic together! 🎩🐇💻

Sure, you can add the monodocs build in the flyte repository as a GitHub Actions workflow step. This can be done by adding a new job in the workflow file .github/workflows/tests.yml. Here is a sample job configuration:

  monodocs:
    runs-on: ubuntu-latest
    steps:
      - name: Fetch the code
        uses: actions/checkout@v2
      - name: Set up Python
        uses: actions/setup-python@v2
        with:
          python-version: 3.9
      - name: Install dependencies
        run: pip install -r requirements.txt
      - name: Build monodocs
        run: make monodocs

Please replace pip install -r requirements.txt and make monodocs with the actual commands to install dependencies and build monodocs. This job will run on every push and pull request, and it will fail if the monodocs build fails. You can find the workflow file here.

To build monodocs in the context of the flyte repository, you would use the make monodocs command. This command will invoke the sphinx-build tool with the -M option, passing monodocs as the target. The source directory is . (the current directory), and the build directory is _build. Any additional options can be passed through the SPHINXOPTS variable. You can find the Makefile here.

The dependencies required to build monodocs in the flyte repository are listed in the doc-requirements.in file in the flyteidl directory of the flyte repository. You can find the file here.

I hope this helps! If you have any other questions, feel free to ask.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant