Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Azure AD OIDC Issuer URl is not correct. #4068

Closed
2 tasks done
EraYaN opened this issue Sep 25, 2023 · 3 comments · Fixed by #4075
Closed
2 tasks done

[Docs] Azure AD OIDC Issuer URl is not correct. #4068

EraYaN opened this issue Sep 25, 2023 · 3 comments · Fixed by #4075
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@EraYaN
Copy link
Contributor

EraYaN commented Sep 25, 2023

Description

https://docs.flyte.org/en/v1.0.0/deployment/cluster_config/auth_setup.html#openid-connect mentions https://login.microsoftonline.com/<tenant-id>/oauth2/v2.0/authorize and the Azure AD provider URL. After trying it, this will result in a 404, because the correct URL for Azure AD (v2) OIDC seems to be https://login.microsoftonline.com/<tenant-id>/v2.0 similar though different. Then it will correctly find the .well-known paths and continue.

Still some issues with token cookie length, but it at least retrieves the tokens.

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@EraYaN EraYaN added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Sep 25, 2023
@welcome
Copy link

welcome bot commented Sep 25, 2023

Thank you for opening your first issue here! 🛠

@davidmirror-ops davidmirror-ops added good first issue Good for newcomers and removed untriaged This issues has not yet been looked at by the Maintainers labels Sep 25, 2023
@davidmirror-ops
Copy link
Contributor

Thank you @EraYaN!
Do you want to submit a PR to fix it?

@EraYaN EraYaN mentioned this issue Sep 26, 2023
Merged
3 tasks
@EraYaN
Copy link
Contributor Author

EraYaN commented Sep 26, 2023

I have opened a PR with the replacement of the URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Azure AD OIDC URL with correct one calcasa/flyte
2 participants
@EraYaN @davidmirror-ops