Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pyflyte not respecting .gitignore in pyflyte init #3903

Open
2 tasks done
zeryx opened this issue Jul 27, 2023 · 3 comments
Open
2 tasks done

[BUG] pyflyte not respecting .gitignore in pyflyte init #3903

zeryx opened this issue Jul 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working fit-and-finish stale

Comments

@zeryx
Copy link

zeryx commented Jul 27, 2023

Describe the bug

pyflyte init generates a new flyte project with a .gitignore. pyflyte respects .gitignores and .dockerignores, which by default contain venv and .venv, however it only respects the .gitignore if the cwd is a git project which by default it isn't.

Expected behavior

I would expect that if I use a venv to manage my local, non-git managed flyte project I'm not accidentally bundling my venv (which could be multiple GB in size) into my flyte tar.gz object.

Additional context to reproduce

pyflyte init foo
cd foo
python -m venv venv
source venv/bin/activate
pip install .....
pyflyte register workflows

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@zeryx zeryx added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 27, 2023
@zeryx zeryx changed the title [BUG] If not using a git repo, but using venv - pyflyte register brings venv in by default [BUG] pyflyte not respecting .gitignore in pyflyte init Jul 27, 2023
@eapolinario
Copy link
Contributor

To decrease the chances of hitting this, what if we made the directory created by pyflyte init a git repo by default? Need to verify what happens if the user doesn't have git installed locally.

@eapolinario eapolinario self-assigned this Jul 31, 2023
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 31, 2023
@eapolinario
Copy link
Contributor

Not the first time we see users hitting this error: #3520

Copy link

github-actions bot commented May 4, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fit-and-finish stale
Projects
None yet
Development

No branches or pull requests

2 participants