You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pyflyte init generates a new flyte project with a .gitignore. pyflyte respects .gitignores and .dockerignores, which by default contain venv and .venv, however it only respects the .gitignore if the cwd is a git project which by default it isn't.
Expected behavior
I would expect that if I use a venv to manage my local, non-git managed flyte project I'm not accidentally bundling my venv (which could be multiple GB in size) into my flyte tar.gz object.
zeryx
changed the title
[BUG] If not using a git repo, but using venv - pyflyte register brings venv in by default
[BUG] pyflyte not respecting .gitignore in pyflyte init
Jul 27, 2023
To decrease the chances of hitting this, what if we made the directory created by pyflyte init a git repo by default? Need to verify what happens if the user doesn't have git installed locally.
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏
Describe the bug
pyflyte init generates a new flyte project with a .gitignore. pyflyte respects .gitignores and .dockerignores, which by default contain
venv
and.venv
, however it only respects the .gitignore if the cwd is a git project which by default it isn't.Expected behavior
I would expect that if I use a venv to manage my local, non-git managed flyte project I'm not accidentally bundling my venv (which could be multiple GB in size) into my flyte tar.gz object.
Additional context to reproduce
pyflyte init foo
cd foo
python -m venv venv
source venv/bin/activate
pip install .....
pyflyte register workflows
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: