You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is because for both _with_override(resource=... and @task(requests=...), they are injected as the node resource override in buildNodeSpec
Expected behavior
For the case of @task(requests=...), the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainer
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
Describe the bug
Note: This bug does not affect the behavior of Flyte, but the logic contains a flaw.
In BuildRawContainer, we do not inject the container resource from the task template. Instead, we inject the resource from parameters.TaskExecMetadata.GetOverrides().GetResources().
This is because for both
_with_override(resource=...
and@task(requests=...)
, they are injected as the node resource override in buildNodeSpecExpected behavior
For the case of
@task(requests=...)
, the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainerAdditional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: