Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Normal container task resource should be not be counted as override resource on the node #3540

Closed
2 tasks done
ByronHsu opened this issue Mar 27, 2023 · 0 comments
Closed
2 tasks done
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@ByronHsu
Copy link
Contributor

ByronHsu commented Mar 27, 2023

Describe the bug

Note: This bug does not affect the behavior of Flyte, but the logic contains a flaw.

In BuildRawContainer, we do not inject the container resource from the task template. Instead, we inject the resource from parameters.TaskExecMetadata.GetOverrides().GetResources().

This is because for both _with_override(resource=... and @task(requests=...), they are injected as the node resource override in buildNodeSpec

Expected behavior

For the case of @task(requests=...), the resource override on the node should be empty, and the resource is injected from tasktemplate at BuildRawContainer

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ByronHsu ByronHsu added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Mar 27, 2023
@ByronHsu ByronHsu closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

1 participant