Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [flytekit] Local execution of launch plan can be incorrect in some cases #3257

Open
2 tasks done
kumare3 opened this issue Jan 23, 2023 · 2 comments
Open
2 tasks done
Labels
bug Something isn't working flytekit FlyteKit Python related issue stale

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jan 23, 2023

Describe the bug

LaunchPlan's can contain - fixed_inputs and default_inputs.
Fixed inputs are not overridable.

But the way launchplans are handled in flytekit local execution today, users can accidentally override fixed inputs. this should fail in the backend compiler, but will not be caught in local execution

this code sample shows how the saved inputs is a combination of the two and
it can be seen here how this will not be dealt with correctly in local execution and even in workflow creation.

Expected behavior

Failure in local execution if a fixed input is overriden

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 23, 2023
@kumare3 kumare3 assigned kumare3 and unassigned kumare3 Jan 31, 2023
@kumare3
Copy link
Contributor Author

kumare3 commented Jan 31, 2023

Check out flyteorg/flytekit#1420, which fixes a similar issue for remote objects.

@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue stale
Projects
None yet
Development

No branches or pull requests

1 participant