Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] -d short flag allowed in pyflyte for both --domain and --destination-dir #3178

Closed
2 tasks done
mcloney-ddm opened this issue Dec 21, 2022 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@mcloney-ddm
Copy link

Describe the bug

When passing -d development for example, sometimes the value gets applied to the --destination-dir instead of / as well as the --domain. To avoid this, short flags should be unique.

Expected behavior

Expected -d to be applied only to the --domain when running pyflyte and not the --destination-dir.

Additional context to reproduce

  1. Run pyflyte register -p flytesnacks -d development my_workflow.py
  2. Launch workflow via Flyte console (or other)
  3. Note that in the Task Details section, the value for --dest-dir is no longer the default /root but development
  4. Workflow crashes with the Destination path is required to download distribution and it should be a directory error (fast_registration.download_distribution())

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@mcloney-ddm mcloney-ddm added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Dec 21, 2022
@welcome
Copy link

welcome bot commented Dec 21, 2022

Thank you for opening your first issue here! 🛠

@mcloney-ddm mcloney-ddm changed the title [BUG] -d short flag allowed in pyflyte for both --domain *and* --destination-dir [BUG] -d short flag allowed in pyflyte for both --domain and --destination-dir Dec 21, 2022
@eapolinario eapolinario added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 22, 2022
@eapolinario eapolinario added this to the 1.3.0 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

No branches or pull requests

3 participants