Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] WhyLogs integration page needs pip install instructions #2897

Closed
2 tasks done
Tracked by #2917
cosmicBboy opened this issue Sep 19, 2022 · 8 comments · Fixed by flyteorg/flytesnacks#903 or flyteorg/flytesnacks#906
Closed
2 tasks done
Tracked by #2917
Assignees
Labels
documentation Improvements or additions to documentation hacktoberfest untriaged This issues has not yet been looked at by the Maintainers

Comments

@cosmicBboy
Copy link
Contributor

Description

https://docs.flyte.org/projects/cookbook/en/latest/auto/integrations/flytekit_plugins/whylogs_examples/index.html

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@cosmicBboy cosmicBboy added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Sep 19, 2022
@samhita-alla
Copy link
Contributor

Also, need to ensure whylogs doc is rendering properly.

@DoraTheExplorax
Copy link

Hi, can you assign me this issue?

@3t8
Copy link
Contributor

3t8 commented Sep 30, 2022

I fixed the rendering of the code blocks. Now you can see the pip installation instructions

@samhita-alla
Copy link
Contributor

Thanks, @3t8 for creating the PR. Will review it shortly.

@samhita-alla
Copy link
Contributor

@3t8, could you please fix the grammar of https://docs.flyte.org/projects/cookbook/en/latest/auto/integrations/flytekit_plugins/whylogs_examples/whylogs_example.html#sphx-glr-auto-integrations-flytekit-plugins-whylogs-examples-whylogs-example-py page as well? There's one class that isn't rendering properly as well; please fix that too.

image

@samhita-alla
Copy link
Contributor

@3t8, are you done, or are you fixing the grammar as well?

@3t8
Copy link
Contributor

3t8 commented Oct 5, 2022

I'm done. I also fixed a few wrong capitalized words

@samhita-alla
Copy link
Contributor

@3t8, merged one PR; awaiting the checks to pass in the other PR. Thanks for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hacktoberfest untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
4 participants