Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Keras types integration #2759

Closed
cosmicBboy opened this issue Aug 11, 2022 · 6 comments
Closed

[Plugin] Keras types integration #2759

cosmicBboy opened this issue Aug 11, 2022 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest plugins Plugins related labels (backend or frontend)

Comments

@cosmicBboy
Copy link
Contributor

cosmicBboy commented Aug 11, 2022

Flyte is an ML- and data- aware orchestrator, it would make sense to support the most popular ML frameworks as first-class citizen types in the Flyte type system.

One of the popular deep learning frameworks is keras, which would make sense to support without installing plugins and simply be activated when a user has it installed, similar to how we're handling pytorch, tensorflow (#2569, #2570, #2571), and sklearn (#2752).

We'll need to follow the conventions set in the flytekit.extras.pytorch module, by doing the following:

  1. the __init__.py file should handle the case where the user doesn't have keras installed.
  2. implement a TypeTransformer for the following classes:
  3. add tests here: https://github.com/flyteorg/flytekit/tree/master/tests/flytekit/unit/extras

Resources

@SmritiSatyanV
Copy link
Contributor

Could I work on this? @cosmicBboy

@ryankarlos
Copy link

ryankarlos commented Oct 18, 2022

@samhita-alla ive added a PR for this

@ryankarlos
Copy link

#take

@dennisobrien
Copy link

There is another issue that is probably a duplicate of this. #2570
And that issue also has a PR in progress. flyteorg/flytekit#1241

@samhita-alla
Copy link
Contributor

@dennisobrien, you're right. @cosmicBboy, which PR shall we close?

@ryankarlos
Copy link

ryankarlos commented Oct 24, 2022

@samhita-alla Ive also added support for Sequential class in this PR - i could port that over to the tensorflow folder and associated scripts once the duplicate PR in flyteorg/flytekit#1241 is merged in, if that helps.
Not sure if support for type transformer for https://keras.io/api/layers/ would be useful as well but happy to add that in too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest plugins Plugins related labels (backend or frontend)
Projects
None yet
Development

No branches or pull requests

5 participants