Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Offload parts of CRD to storage #2705

Closed
2 tasks done
ckiosidis opened this issue Jul 20, 2022 · 3 comments
Closed
2 tasks done

[Core feature] Offload parts of CRD to storage #2705

ckiosidis opened this issue Jul 20, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ckiosidis
Copy link
Contributor

ckiosidis commented Jul 20, 2022

Motivation: Why do you think this is important?

The larger the execution the larger the flyteworkflow resource size.
At times we have observed flyteworkflow larger than 1.3MB, which is the upper size limit for crds in GKE.

We believe that updating large resources can also cause performance degradation issues.

Offloading some static parts of the CRD to storage (s3/gcs/etc) will help make the flyteworkflow lighter and more easily manageable.

Goal: What should the final outcome look like, ideally?

Reduce the size of flyteworkflow kubernetes resources for large Flyte Workflows.
Large flyte workflows can be workflows with a lot of nodes or with big subworkflows.

Flyteadmin would write the parts of the CRD to storage before creating the FlyteWorkflow resource on kubernetes.
Flytepropeller would read the CRD parts when handling the FlyteWorkflow resource.

Describe alternatives you've considered

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ckiosidis ckiosidis added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 20, 2022
@hamersaw hamersaw removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 20, 2022
@hamersaw hamersaw added this to the 1.2.0 milestone Jul 20, 2022
@ckiosidis
Copy link
Contributor Author

Should this behaviour be configurable from flyteadmin via configuration?

@hamersaw
Copy link
Contributor

Should this behaviour be configurable from flyteadmin via configuration?

I think so. To begin with, lets just add a top-level option which handles all workflows. If we find it would be helpful we could make this per-workflow as well.

@ckiosidis
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants