Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Add Container Configuration to Default PodTemplate #2703

Closed
2 tasks done
hamersaw opened this issue Jul 19, 2022 · 1 comment · Fixed by flyteorg/flyteplugins#280
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@hamersaw
Copy link
Contributor

Motivation: Why do you think this is important?

Currently the default PodTemplate in FlytePropeller allows users to set a base PodSpec configuration for all k8s Pods started by Flyte. This is very flexible in supporting all Pod configuration options without requiring Flyte updates. However, this configuration does not extend into specific Containers. In the current approach, Flyte overrides the default PodTemplate containers during initialization.

Goal: What should the final outcome look like, ideally?

Users should be able to add configuration to the default PodTemplate containers that gets applied to containers in Flyte Pods. This improves the configurability of Flyte. One approach is to use the container names in the PodTemplate to map to Flyte Pod container names. For example a container in the PodTemplate named "primary_container_name" would serve as the base to all primary containers in k8s container and pod plugins.

Describe alternatives you've considered

Leave container configuration unsupported or continue adding one-off configuration options to the k8s plugin to support container specific configuration options. Both of these options is undesired.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@hamersaw hamersaw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jul 19, 2022
@hamersaw hamersaw added this to the 1.3.0 milestone Jul 19, 2022
@hamersaw hamersaw removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 19, 2022
@hamersaw hamersaw self-assigned this Jul 19, 2022
@hamersaw hamersaw modified the milestones: 1.3.0, 1.2.0 Jul 20, 2022
@hamersaw
Copy link
Contributor Author

cc @niliayu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant