Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FlyteCTL Feature] Use Launchplan with latest version for scheduled workflows #2329

Closed
2 tasks done
pmahindrakar-oss opened this issue Apr 7, 2022 · 2 comments · Fixed by flyteorg/flytectl#324
Closed
2 tasks done
Assignees
Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI
Milestone

Comments

@pmahindrakar-oss
Copy link
Contributor

Describe the feature/command for FlyteCTL

Currently for activating a launch plan with scheduled workflow.
Users have to

  • deactivate the old launch plan version with the scheduled workflow
  • register the new launch plan version with the scheduled workflow
  • activate the new launch plan version with the scheduled workflow

TO reduce the number of steps the proposal is to do all this during register with additional flag

Provide a possible output or UX example

flytectl register file  *  -d development  -p flytesnacks --version v2  --enableSchedule

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Apr 7, 2022
@pmahindrakar-oss
Copy link
Contributor Author

cc : @kumare3 @stephen37

@pmahindrakar-oss pmahindrakar-oss added flytectl Issues related to flytectl -Flytes CLI and removed untriaged This issues has not yet been looked at by the Maintainers labels Apr 7, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.1 milestone Apr 7, 2022
@EngHabu
Copy link
Contributor

EngHabu commented May 4, 2022

Discussed offline, let's change the logic to:

  • Register the new version
  • Activate the new version (Admin will automatically deactivate the old LP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytectl Issues related to flytectl -Flytes CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants