Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Clean-up opta flyte.yaml #2116

Closed
2 tasks done
kumare3 opened this issue Jan 31, 2022 · 1 comment · Fixed by #2161, #2245 or #2337
Closed
2 tasks done

[BUG] Clean-up opta flyte.yaml #2116

kumare3 opened this issue Jan 31, 2022 · 1 comment · Fixed by #2161, #2245 or #2337
Assignees
Labels
adoption Improve the speed of getting started and adoption for new uses bug Something isn't working

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jan 31, 2022

Describe the bug

The Opta deployment flyte.yaml, contains some unnecessary sections like
setting up SQS / SNS, granting Cloudwatch eventss role.
These can be found here - https://github.com/flyteorg/flyte/blob/master/opta/aws/flyte.yaml#L14-L39

Expected behavior

Ideally the only things user should be expected to configure is

  1. Setup EKS (or reuse an existing one)
  2. Setup S3 (or reuse an existing one)
  3. Setup Postgres
  4. Setup role to access S3

This is all, but the current deployment seems to be more complicated than it needs to be.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added bug Something isn't working adoption Improve the speed of getting started and adoption for new uses labels Jan 31, 2022
@EngHabu EngHabu added this to the 0.19.3 - Feb 2021 milestone Feb 1, 2022
@EngHabu EngHabu reopened this Apr 8, 2022
@EngHabu
Copy link
Contributor

EngHabu commented Apr 8, 2022

Thanks to Austin Bennett for catching this. We seem to have lingering references to these module outputs in the opta file
e.g. https://github.com/flyteorg/flyte/blob/master/opta/aws/flyte.yaml#L115

@evalsocket this file is now broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adoption Improve the speed of getting started and adoption for new uses bug Something isn't working
Projects
None yet
3 participants