Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there #1809

Closed
2 tasks done
EngHabu opened this issue Nov 9, 2021 · 0 comments · Fixed by flyteorg/flyteadmin#285
Closed
2 tasks done

[Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there #1809

EngHabu opened this issue Nov 9, 2021 · 0 comments · Fixed by flyteorg/flyteadmin#285
Assignees
@pmahindrakar-oss
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone
0.19.2 - Jan 2021

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Nov 9, 2021

Describe the issue

If an access token is sent to flyteadmin with multiple audiences in the aud field, admin should not fail token validation as long as one of these audiences is one it's looking for.

What if we do not do this?

Extra setup on the IdP side.

Related component(s)

flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@EngHabu EngHabu added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Nov 9, 2021
@EngHabu EngHabu added this to the 0.19.0 - Eagle milestone Nov 9, 2021
@EngHabu EngHabu mentioned this issue Nov 9, 2021
Merged
8 tasks
@hamersaw hamersaw changed the title [Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there 9 Feb 2, 2022
@pmahindrakar-oss pmahindrakar-oss changed the title 9 Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there Feb 3, 2022
@pmahindrakar-oss pmahindrakar-oss changed the title Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there [Housekeeping] FlyteAdmin Auth should allow multiple audiences as long as the one it's looking for is there Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmahindrakar-oss pmahindrakar-oss

Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Milestone
0.19.2 - Jan 2021
Development

Successfully merging a pull request may close this issue.

Allow tokens with multiple audiences as long as one matches flyteorg/flyteadmin
2 participants
@EngHabu @pmahindrakar-oss