From afd9d91555f2c5b767b155b809628d500eedc4d6 Mon Sep 17 00:00:00 2001 From: Ketan Umare Date: Mon, 9 Mar 2020 10:06:19 -0700 Subject: [PATCH] Adds Pull request template for flyteidl (#47) --- .../lyft/pull_request_template/Readme.rst | 8 ++++++ .../pull_request_template.md | 26 +++++++++++++++++++ .../lyft/pull_request_template/update.sh | 12 +++++++++ flyteidl/boilerplate/update.cfg | 1 + flyteidl/pull_request_template.md | 26 +++++++++++++++++++ 5 files changed, 73 insertions(+) create mode 100644 flyteidl/boilerplate/lyft/pull_request_template/Readme.rst create mode 100644 flyteidl/boilerplate/lyft/pull_request_template/pull_request_template.md create mode 100755 flyteidl/boilerplate/lyft/pull_request_template/update.sh create mode 100644 flyteidl/pull_request_template.md diff --git a/flyteidl/boilerplate/lyft/pull_request_template/Readme.rst b/flyteidl/boilerplate/lyft/pull_request_template/Readme.rst new file mode 100644 index 0000000000..b85a4ea121 --- /dev/null +++ b/flyteidl/boilerplate/lyft/pull_request_template/Readme.rst @@ -0,0 +1,8 @@ +Pull Request Template +~~~~~~~~~~~~~~~~~~~~~ + +Provides a Pull Request template. + +**To Enable:** + +Add ``lyft/golang_test_targets`` to your ``boilerplate/update.cfg`` file. diff --git a/flyteidl/boilerplate/lyft/pull_request_template/pull_request_template.md b/flyteidl/boilerplate/lyft/pull_request_template/pull_request_template.md new file mode 100644 index 0000000000..d2becf38b7 --- /dev/null +++ b/flyteidl/boilerplate/lyft/pull_request_template/pull_request_template.md @@ -0,0 +1,26 @@ +# TL;DR +_Please replace this text with a description of what this PR accomplishes._ + +## Type + - [ ] Bug Fix + - [ ] Feature + - [ ] Plugin + +## Are all requirements met? + + - [ ] Code completed + - [ ] Smoke tested + - [ ] Unit tests added + - [ ] Code documentation added + - [ ] Any pending items have an associated Issue + +## Complete description + _How did you fix the bug, make the feature etc. Link to any design docs etc_ + +## Tracking Issue +https://github.com/lyft/flyte/issues/ + +## Follow-up issue +_NA_ +OR +_https://github.com/lyft/flyte/issues/_ diff --git a/flyteidl/boilerplate/lyft/pull_request_template/update.sh b/flyteidl/boilerplate/lyft/pull_request_template/update.sh new file mode 100755 index 0000000000..13f0c3b57d --- /dev/null +++ b/flyteidl/boilerplate/lyft/pull_request_template/update.sh @@ -0,0 +1,12 @@ +#!/usr/bin/env bash + +# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES. +# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY: +# +# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst + +set -e + +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" + +cp ${DIR}/pull_request_template.md ${DIR}/../../../pull_request_template.md diff --git a/flyteidl/boilerplate/update.cfg b/flyteidl/boilerplate/update.cfg index 5c54f64c93..a1b1bff989 100644 --- a/flyteidl/boilerplate/update.cfg +++ b/flyteidl/boilerplate/update.cfg @@ -1,3 +1,4 @@ lyft/golang_test_targets lyft/golangci_file lyft/golang_support_tools +lyft/pull_request_template diff --git a/flyteidl/pull_request_template.md b/flyteidl/pull_request_template.md new file mode 100644 index 0000000000..d2becf38b7 --- /dev/null +++ b/flyteidl/pull_request_template.md @@ -0,0 +1,26 @@ +# TL;DR +_Please replace this text with a description of what this PR accomplishes._ + +## Type + - [ ] Bug Fix + - [ ] Feature + - [ ] Plugin + +## Are all requirements met? + + - [ ] Code completed + - [ ] Smoke tested + - [ ] Unit tests added + - [ ] Code documentation added + - [ ] Any pending items have an associated Issue + +## Complete description + _How did you fix the bug, make the feature etc. Link to any design docs etc_ + +## Tracking Issue +https://github.com/lyft/flyte/issues/ + +## Follow-up issue +_NA_ +OR +_https://github.com/lyft/flyte/issues/_