From 9c2f598a2582bf555b8504edd5746c379989b83f Mon Sep 17 00:00:00 2001
From: Yuvraj <code@evalsocket.dev>
Date: Fri, 3 Sep 2021 21:34:57 +0530
Subject: [PATCH] Added minio  nodeport to 30084 in helm chart (#1426)

* Added minio as nodeport

Signed-off-by: Yuvraj <code@evalsocket.dev>

* make helm

Signed-off-by: Yuvraj <code@evalsocket.dev>
---
 charts/flyte/templates/minio/service.yaml    |  2 +-
 charts/flyte/values-gcp.yaml                 |  7 ++
 charts/flyte/values-sandbox.yaml             |  5 +-
 deployment/gcp/flyte_helm_generated.yaml     | 76 --------------------
 deployment/sandbox/flyte_helm_generated.yaml |  4 +-
 5 files changed, 14 insertions(+), 80 deletions(-)

diff --git a/charts/flyte/templates/minio/service.yaml b/charts/flyte/templates/minio/service.yaml
index b9b56cc1bc..822d77ebca 100644
--- a/charts/flyte/templates/minio/service.yaml
+++ b/charts/flyte/templates/minio/service.yaml
@@ -14,7 +14,7 @@ spec:
   {{- end }}
   ports:
   - name: minio
-    port: 9000
+    port: 30084
     protocol: TCP
     targetPort: minio
   selector: {{ include "minio.selectorLabels" . | nindent 4 }}
diff --git a/charts/flyte/values-gcp.yaml b/charts/flyte/values-gcp.yaml
index 7fa40b2a3f..6e3e65a8bb 100644
--- a/charts/flyte/values-gcp.yaml
+++ b/charts/flyte/values-gcp.yaml
@@ -46,3 +46,10 @@ configmap:
         spark: spark
         container_array: k8s-array
         pytorch: pytorch
+
+#
+# MINIO
+#
+
+minio:
+  enabled: false
diff --git a/charts/flyte/values-sandbox.yaml b/charts/flyte/values-sandbox.yaml
index 34e6229722..6d6c3e3390 100644
--- a/charts/flyte/values-sandbox.yaml
+++ b/charts/flyte/values-sandbox.yaml
@@ -55,7 +55,10 @@ postgres:
 # MINIO
 #
 
-minio: {}
+minio:
+  service:
+    annotations: { }
+    type: NodePort
 
 #
 # CONTOUR
diff --git a/deployment/gcp/flyte_helm_generated.yaml b/deployment/gcp/flyte_helm_generated.yaml
index ee4ef4de56..1d9a070fec 100644
--- a/deployment/gcp/flyte_helm_generated.yaml
+++ b/deployment/gcp/flyte_helm_generated.yaml
@@ -2611,28 +2611,6 @@ spec:
     app.kubernetes.io/name: datacatalog
     app.kubernetes.io/instance: flyte
 ---
-# Source: flyte/templates/minio/service.yaml
-apiVersion: v1
-kind: Service
-metadata:
-  name: minio
-  namespace: flyte
-  labels: 
-    app.kubernetes.io/name: minio
-    app.kubernetes.io/instance: flyte
-    helm.sh/chart: flyte-v0.1.10
-    app.kubernetes.io/managed-by: Helm
-spec:
-  type: ClusterIP
-  ports:
-  - name: minio
-    port: 9000
-    protocol: TCP
-    targetPort: minio
-  selector: 
-    app.kubernetes.io/name: minio
-    app.kubernetes.io/instance: flyte
----
 # Source: flyte/templates/postgres/service.yaml
 apiVersion: v1
 kind: Service
@@ -3390,60 +3368,6 @@ spec:
           name: datacatalog-config
         name: config-volume
 ---
-# Source: flyte/templates/minio/deployment.yaml
-apiVersion: apps/v1
-kind: Deployment
-metadata:
-  name: minio
-  namespace: flyte
-  labels: 
-    app.kubernetes.io/name: minio
-    app.kubernetes.io/instance: flyte
-    helm.sh/chart: flyte-v0.1.10
-    app.kubernetes.io/managed-by: Helm
-spec:
-  replicas: 1
-  selector:
-    matchLabels: 
-      app.kubernetes.io/name: minio
-      app.kubernetes.io/instance: flyte
-  template:
-    metadata:
-      labels: 
-        app.kubernetes.io/name: minio
-        app.kubernetes.io/instance: flyte
-        helm.sh/chart: flyte-v0.1.10
-        app.kubernetes.io/managed-by: Helm
-    spec:
-      containers:
-      - image: "minio/minio:RELEASE.2020-12-16T05-05-17Z"
-        imagePullPolicy: "IfNotPresent"
-        name: minio
-        args:
-        - server
-        - /data
-        env:
-        - name: MINIO_ACCESS_KEY
-          value: minio
-        - name: MINIO_SECRET_KEY
-          value: miniostorage
-        ports:
-        - containerPort: 9000
-          name: minio
-        resources: 
-          limits:
-            cpu: 200m
-            memory: 512Mi
-          requests:
-            cpu: 10m
-            memory: 128Mi
-        volumeMounts:
-        - name: minio-storage
-          mountPath: /var/lib/minioql/data
-      volumes:
-      - name: minio-storage
-        emptyDir: {}
----
 # Source: flyte/templates/postgres/deployment.yaml
 apiVersion: apps/v1
 kind: Deployment
diff --git a/deployment/sandbox/flyte_helm_generated.yaml b/deployment/sandbox/flyte_helm_generated.yaml
index 892013d4bf..54bae53f4b 100644
--- a/deployment/sandbox/flyte_helm_generated.yaml
+++ b/deployment/sandbox/flyte_helm_generated.yaml
@@ -2714,10 +2714,10 @@ metadata:
     helm.sh/chart: flyte-v0.1.10
     app.kubernetes.io/managed-by: Helm
 spec:
-  type: ClusterIP
+  type: NodePort
   ports:
   - name: minio
-    port: 9000
+    port: 30084
     protocol: TCP
     targetPort: minio
   selector: