diff --git a/flyteadmin/pkg/manager/impl/execution_manager.go b/flyteadmin/pkg/manager/impl/execution_manager.go index 01bf6c7d6c..436f1b0fce 100644 --- a/flyteadmin/pkg/manager/impl/execution_manager.go +++ b/flyteadmin/pkg/manager/impl/execution_manager.go @@ -1770,7 +1770,11 @@ func (m *ExecutionManager) GetExecutionData( id.Project, id.Domain, executionModel.InputsURI.String(), - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read inputs during execution [%v]: %v", id, err) + } return err }) @@ -1786,7 +1790,11 @@ func (m *ExecutionManager) GetExecutionData( cluster, id.Project, id.Domain, - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read outputs during execution [%v]: %v", id, err) + } return err }) diff --git a/flyteadmin/pkg/manager/impl/node_execution_manager.go b/flyteadmin/pkg/manager/impl/node_execution_manager.go index 4c6b52fe35..1747381256 100644 --- a/flyteadmin/pkg/manager/impl/node_execution_manager.go +++ b/flyteadmin/pkg/manager/impl/node_execution_manager.go @@ -575,7 +575,11 @@ func (m *NodeExecutionManager) GetNodeExecutionData( id.Project, id.Domain, nodeExecution.InputUri, - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read inputs during execution [%v]: %v", id, err) + } return err }) @@ -591,7 +595,11 @@ func (m *NodeExecutionManager) GetNodeExecutionData( cluster, id.Project, id.Domain, - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read outputs during execution [%v]: %v", id, err) + } return err }) diff --git a/flyteadmin/pkg/manager/impl/task_execution_manager.go b/flyteadmin/pkg/manager/impl/task_execution_manager.go index 0e88ab1998..4fab87a5b4 100644 --- a/flyteadmin/pkg/manager/impl/task_execution_manager.go +++ b/flyteadmin/pkg/manager/impl/task_execution_manager.go @@ -303,6 +303,7 @@ func (m *TaskExecutionManager) GetTaskExecutionData(ctx context.Context, if err := validation.ValidateTaskExecutionIdentifier(request.Id); err != nil { logger.Debugf(ctx, "Invalid identifier [%+v]: %v", request.Id, err) } + ctx = getTaskExecutionContext(ctx, request.Id) group, groupCtx := errgroup.WithContext(ctx) var taskExecution *admin.TaskExecution @@ -351,7 +352,11 @@ func (m *TaskExecutionManager) GetTaskExecutionData(ctx context.Context, id.Project, id.Domain, taskExecution.InputUri, - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read inputs during execution [%v]: %v", id, err) + } return err }) @@ -367,7 +372,11 @@ func (m *TaskExecutionManager) GetTaskExecutionData(ctx context.Context, cluster, id.Project, id.Domain, - objectStore) + objectStore, + ) + if err != nil { + logger.Errorf(ctx, "failed to read outputs during execution [%v]: %v", id, err) + } return err }) diff --git a/flyteadmin/pkg/manager/impl/util/data.go b/flyteadmin/pkg/manager/impl/util/data.go index 828b4c6ccf..975e43e26d 100644 --- a/flyteadmin/pkg/manager/impl/util/data.go +++ b/flyteadmin/pkg/manager/impl/util/data.go @@ -150,7 +150,6 @@ func GetOutputs(ctx context.Context, err = readFromDataPlane(ctx, objectStore, cluster, project, domain, closure.GetOutputUri(), fullOutputs) } } - return fullOutputs, &outputsURLBlob, err }