From 7c57d51c0b221c5e54c31afc16160f38b7dfcddf Mon Sep 17 00:00:00 2001 From: "Ethan Brown (Domino)" <111539728+ddl-ebrown@users.noreply.github.com> Date: Wed, 27 Mar 2024 05:05:27 -0700 Subject: [PATCH] Add flyte-core missing webhook priorityClassName (#4987) - All the other pods can have their priorityClassName set except for the webhook Signed-off-by: ddl-ebrown --- charts/flyte-core/README.md | 1 + charts/flyte-core/templates/propeller/webhook.yaml | 3 +++ charts/flyte-core/values.yaml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/charts/flyte-core/README.md b/charts/flyte-core/README.md index fe129d4e77..27086c0505 100644 --- a/charts/flyte-core/README.md +++ b/charts/flyte-core/README.md @@ -290,6 +290,7 @@ helm install gateway bitnami/contour -n flyte | storage.s3.secretKey | string | `""` | AWS IAM user secret access key to use for S3 bucket auth, only used if authType is set to accesskey | | storage.type | string | `"sandbox"` | Sets the storage type. Supported values are sandbox, s3, gcs and custom. | | webhook.enabled | bool | `true` | enable or disable secrets webhook | +| webhook.priorityClassName | string | `""` | Sets priorityClassName for webhook pod | | webhook.resources.requests.cpu | string | `"200m"` | | | webhook.resources.requests.ephemeral-storage | string | `"500Mi"` | | | webhook.resources.requests.memory | string | `"500Mi"` | | diff --git a/charts/flyte-core/templates/propeller/webhook.yaml b/charts/flyte-core/templates/propeller/webhook.yaml index e34241d905..90241a69f8 100644 --- a/charts/flyte-core/templates/propeller/webhook.yaml +++ b/charts/flyte-core/templates/propeller/webhook.yaml @@ -39,6 +39,9 @@ spec: securityContext: {{ tpl (toYaml .) $ | nindent 8 }} {{- end }} serviceAccountName: {{ template "flyte-pod-webhook.name" . }} + {{- if .Values.webhook.priorityClassName }} + priorityClassName: {{ .Values.webhook.priorityClassName }} + {{- end }} {{- if .Values.webhook.enabled }} initContainers: - name: generate-secrets diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml index f14c6dea2b..944bc84735 100755 --- a/charts/flyte-core/values.yaml +++ b/charts/flyte-core/values.yaml @@ -444,6 +444,8 @@ secrets: webhook: # -- enable or disable secrets webhook enabled: true + # -- Sets priorityClassName for webhook pod + priorityClassName: "" # -- Configuration for service accounts for the webhook serviceAccount: # -- Should a service account be created for the webhook