From 502d99a0723e61b634aca71da779db025246e02a Mon Sep 17 00:00:00 2001 From: Dan Rammer Date: Wed, 6 Dec 2023 10:36:40 -0600 Subject: [PATCH] bypassing cache lookup when node is in predicatephase (#4524) Signed-off-by: Daniel Rammer Signed-off-by: Paul Dittamo --- flytepropeller/pkg/controller/nodes/executor.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flytepropeller/pkg/controller/nodes/executor.go b/flytepropeller/pkg/controller/nodes/executor.go index 5e1cbe4f51..8e96ee9645 100644 --- a/flytepropeller/pkg/controller/nodes/executor.go +++ b/flytepropeller/pkg/controller/nodes/executor.go @@ -941,7 +941,7 @@ func (c *nodeExecutor) handleNotYetStartedNode(ctx context.Context, dag executor } var cacheStatus *catalog.Status - if cacheHandler, ok := h.(interfaces.CacheableNodeHandler); ok { + if cacheHandler, ok := h.(interfaces.CacheableNodeHandler); p.GetPhase() != handler.EPhaseSkip && ok { cacheable, _, err := cacheHandler.IsCacheable(ctx, nCtx) if err != nil { logger.Errorf(ctx, "failed to determine if node is cacheable with err '%s'", err.Error())