Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when using rails_best_practices with Overcommit #351

Open
Diego-Zulu opened this issue Nov 12, 2019 · 0 comments
Open

Problem when using rails_best_practices with Overcommit #351

Diego-Zulu opened this issue Nov 12, 2019 · 0 comments

Comments

@Diego-Zulu
Copy link

Diego-Zulu commented Nov 12, 2019

Hey there!

Some weeks ago I tried out the RailsBestPractices hook with Overcommit to no avail. I opened an issue to ask about my problem, and it turns out it may be related to how rails_best_practices expect explicit files to be passed. However, I still have not found the cause of the problem.

I tried running this (which is what overcommit ends up running to my understanding):

echo app/controllers/application_controller.rb config/routes.rb | tr ',' '\n' | xargs bundle exec rails_best_practices

And this works perfectly (by this I mean it detectes warnings in those two files correctly), so I don't really know what could be going wrong with that.

Can anyone give me a hand with this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant