Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate): only trigger tests from impacted packages #39

Merged
merged 23 commits into from
Mar 26, 2024

Conversation

azlam-abdulsalam
Copy link

@azlam-abdulsalam azlam-abdulsalam commented Mar 22, 2024

  • feat(validate): only trigger tests for impacted packages

Only trigger tests for impacted packages, other packages will be installed for synchronizing the
org. If the same org is retried, it will be skipped

BREAKING CHANGE: Changes the earlier behaviour across all validation modes

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (995bdbf) to head (6ea44e0).
Report is 73 commits behind head on main.

Files Patch % Lines
...s/sfp-cli/src/core/package/diff/PackageDiffImpl.ts 44.44% 5 Missing ⚠️
packages/sfp-cli/src/core/org/SFPOrg.ts 81.25% 3 Missing ⚠️
packages/sfp-cli/src/core/git/Git.ts 0.00% 2 Missing ⚠️
...e/package/packageCreators/CreateDiffPackageImpl.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   46.26%   46.28%   +0.02%     
==========================================
  Files          73       73              
  Lines        2823     2830       +7     
  Branches      323      324       +1     
==========================================
+ Hits         1306     1310       +4     
- Misses       1492     1495       +3     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Only run tests for changed packages in the PR
3 participants