Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(fetch package id): add new logic for promoted pcks #20

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

Rocko1204
Copy link
Collaborator

@Rocko1204 Rocko1204 commented Feb 21, 2024

#18

This fix/feature checks for promoted versions on devhub when the pck dependecies are flagged with the RELEASED suffix.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at flxbl-sfp Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.36%. Comparing base (5aca75a) to head (f378938).
Report is 71 commits behind head on main.

Files Patch % Lines
.../package/dependencies/PackageDependencyResolver.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   46.28%   46.36%   +0.07%     
==========================================
  Files          73       73              
  Lines        2830     2836       +6     
  Branches      324      328       +4     
==========================================
+ Hits         1310     1315       +5     
- Misses       1495     1496       +1     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam azlam-abdulsalam added this to the March 2024 milestone Feb 23, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024

CLA assistant check
All committers have signed the CLA.

@azlam-abdulsalam azlam-abdulsalam force-pushed the main branch 2 times, most recently from e1b48d7 to 99a1e8f Compare April 15, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot specify dependency on RELEASED version
4 participants