Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfp impact releaseconfig with filterByChangesInBranch option use tag for package descriptor diff #129

Open
alanjaouen opened this issue Oct 10, 2024 · 1 comment
Open

sfp impact releaseconfig with filterByChangesInBranch option use tag for package descriptor diff #129

alanjaouen opened this issue Oct 10, 2024 · 1 comment
Labels
analysis

Comments

@alanjaouen
Copy link

Describe the bug
When using sfp impact releaseconfig --releaseconfig=releases/definitions --filterByChangesInBranch --basebranch=main --branch=HEAD
with no changes in branch, commands return impacted packages.

To Reproduce

  • change package descriptor in basebranch.
  • create a branch from basebranch
  • sfp impact releaseconfig

Expected behavior
When using filterByChangesInBranch option, package descriptor should not be diff against latest tag

Platform Details (please complete the following information):

  • OS: windows
  • Version [e.g. CLI Version eg: 1.6.6] : 39.2.2
  • Salesforce CLI(sfdx cli) Version: @salesforce/cli/2.60.13 win32-x64 node-v20.17.0
@alanjaouen alanjaouen mentioned this issue Oct 10, 2024
Open
5 tasks
@azlam-abdulsalam
Copy link

@alanjaouen Checking into this and thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanjaouen @azlam-abdulsalam