GA flux_bootstrap_git

[stefanprodan]

This umbrella issue tracks the work required to GA the flux_bootstrap_git resource.

Tasks:

• e2e tests for flux_bootstrap_git using GitHub and Kubernetes Kind
• promote flux_bootstrap_git as the recommended bootstrap procedure (Flux website & Terraform registry)
• cleanup the docs section in https://registry.terraform.io/providers/fluxcd/flux/latest/docs (remove old guides)
• deprecate flux_install and flux_sync data sources and point people to the community Helm charts for those that are using the data source without bootstrap

TODO guides:

• Migration Guide
• GitHub Guide
• GitLab Guide

Part of: fluxcd/flux2#3735

[smurfralf]

WRT task 4 "deprecate flux_install ... " I want to note that our way of working uses the flux_install data source without the flux_sync data source to deploy flux. This is in order to explicitly control what and when deployments/upgrades happen using similar techniques as our other fundamental services. So while flux_bootstrap_git may be a full replacement for flux_install + flux_sync, it would be good if standalone use of flux_install is not deprecated.

[phillebaba]

@smurfralf there have been a couple of people who have shared their use case with the datasoruces which I have never seen before. Some of these are mentioned in #399. My issue with the datasources is that it does an incomplete job at generating the manifests, especially with regards to customizing them.

We obviously need to discuss what we should support in the future. One of my worries is however that people who install with flux_install and flux_sync will stick to that method. Those people need to switch to the new resource because it has turned out to be impossible to support every single users specific installation problems. The new resource has enabled me to debug user issues in a way that was not possible before.

[stefanprodan]

Instead of flux_install people can use the community Helm charts and deploy Flux without bootstrapping using the Helm TF provider. The sole purpose of the terraform-provider-flux is to enable bootstrap the same way the Flux CLI does it.

[smurfralf]

@stefanprodan @phillebaba Agree with your observations about limitations of flux_install. We'll take a look at migrating to the helm chart. It looks like it is pretty well maintained even though its readme starts with "These helm charts are maintained and released by the fluxcd-community on a best effort basis."

[jamiezieziula]

@stefanprodan - I don't see this mentioned here, but by GA - will this resource support conditionally installing flux to the cluster? I mentioned this here - but I currently use the terraform resources to install flux and then create >1 flux sync objects. In its current implementation, there is no way to do this given that each flux_bootstrap_git resource wants to install all the flux crds, etc.

I opened a formal issue here

[nick4fake]

I have just finished setting up cluster following https://registry.terraform.io/providers/fluxcd/flux/latest/docs/guides/gitlab just to randomly notice it is going to be deprecated. Could you please update docs to mention it?