Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCIRepository verification doesn't not support contextual login #915

Closed
souleb opened this issue Sep 26, 2022 · 1 comment · Fixed by #916
Closed

OCIRepository verification doesn't not support contextual login #915

souleb opened this issue Sep 26, 2022 · 1 comment · Fixed by #916
Assignees
Labels
area/oci OCI related issues and pull requests bug Something isn't working

Comments

@souleb
Copy link
Member

souleb commented Sep 26, 2022

In #876, artifact signature verification with cosign has been added.

When calling

err := r.verifyOCISourceSignature(ctx, obj, url, keychain)

We pass the keychain fetch from a secret containing the needed credentials, but we do not take into account the authenticator that is retrieved from the cloud provider.

@souleb souleb added the bug Something isn't working label Sep 26, 2022
@souleb souleb self-assigned this Sep 26, 2022
@souleb souleb added the area/oci OCI related issues and pull requests label Sep 26, 2022
@stefanprodan
Copy link
Member

Not only that, the verify function also doesn't set insecure and any transport customisations like root CAs 😱

Thanks @souleb for finding this before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants