Add rate limiter to event http servers #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
feature/rate-limit
branch
2 times, most recently
from
4927594
to
061fae5
Compare
phillebaba
commented
Mar 21, 2021
stefanprodan
requested changes
Mar 22, 2021
phillebaba
force-pushed
the
feature/rate-limit
branch
3 times, most recently
from
ef07dc0
to
59234b1
Compare
phillebaba
force-pushed
the
feature/rate-limit
branch
2 times, most recently
from
fd9526d
to
95c293e
Compare
phillebaba
changed the title
phillebaba
force-pushed
the
feature/rate-limit
branch
from
95c293e
to
da37866
Compare
stefanprodan
requested changes
Apr 1, 2021
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
feature/rate-limit
branch
from
da37866
to
e58fc2c
Compare
added 3 commits
April 1, 2021 10:21
Signed-off-by: Philip Laine <[email protected]>
Signed-off-by: Philip Laine <[email protected]>
Signed-off-by: Philip Laine <[email protected]>
stefanprodan
reviewed
Apr 1, 2021
Signed-off-by: Philip Laine <[email protected]>
phillebaba
changed the title
stefanprodan
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rate limiter to the events http server. The limiters are keyed based on the request.
The event endpoint is keyed based on the involved object, severity of the event, and if present reference. A new severity for a throttled involved object should not be throttled and the previous severity throttling should be reset. This is useful when KC or HC will reconcile a resource multiple times if the reconcile errors. A large amount of duplicate events will be sent during a short amount of time until the back off becomes large enough. This protects NC from spamming providers with the same events.
Fixes #158
Fixes #179