Add support for GitHub enterprise commit status #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
commented
Mar 16, 2021
| client := github.NewClient(tc) | ||
| if baseUrl.Host != "github.com" { | ||
| client, err = github.NewEnterpriseClient(host, host, tc) |
There was a problem hiding this comment.
Not sure if the api and upload url should be the same. Right now it will be easiest to do it this way, but there may be instances where these are different.
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
feature/github-enterprise
branch
from
c247f5f
to
f030be3
Compare
|
for me this is working:
|
|
@paschdan thanks! Really appreciate you taking the time to verify this. |
stefanprodan
changed the title
stefanprodan
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Github enterprise clients by checking the host of the url. If it is not github.com it is assumed that the enterprise client should be used.
Fixes #161