Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 status in generic webhook is treated as error #441

Open
makkes opened this issue Nov 16, 2022 · 0 comments
Open

204 status in generic webhook is treated as error #441

makkes opened this issue Nov 16, 2022 · 0 comments
Labels
area/alerting Alerting related issues and PRs bug Something isn't working

Comments

@makkes
Copy link
Member

makkes commented Nov 16, 2022

When a webhook configured through the generic or generic-hmac Provider returns an HTTP status of 204 an error is logged:

{"level":"error","ts":"2022-11-16T14:28:39.167Z","logger":"event-server","msg":"failed to send notification","reconciler kind":"HelmRelease","name":"metallb","namespace":"metallb","error":"postMessage failed: request failed with status code 204, "}

I think we should treat any 2xx status as success.

@makkes makkes added bug Something isn't working area/alerting Alerting related issues and PRs labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant