Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quay.io: TOO_MANY_TAGS_REQUESTED requested limit 1000 is too high, max is 100 #585

Open
carl-reverb opened this issue Jun 21, 2024 · 10 comments

Comments

@carl-reverb
Copy link

Hello, so we have run into an issue that makes us unable to use Image Automation with some Docker Registries which limit PageSize on the v2/.../.../tags/list endpoint.

scan failed: GET https://quay.io/v2/pganalyze/collector/tags/list?n=1000: TOO_MANY_TAGS_REQUESTED: Too many tags requested; requested limit 1000 is too high, max is 100

In order to resume using Image Automation with Quay.io, we'd need some way of setting pageSize on the ImageRepository.

The underlying go-containerregistry.remote already has a withPageSize function.

https://github.com/google/go-containerregistry/blob/main/pkg/v1/remote/options.go#L292

@gionn
Copy link

gionn commented Jun 21, 2024

just tried reaching Quay on X https://x.com/gionn/status/1804162576382664972, it broke all of our Flux automations.

@stefanprodan stefanprodan changed the title Some Docker Registries impose page size limit, add configurable pageSize to ImageRepository Quay.io: error requested limit 1000 is too high, max is 100 Jun 21, 2024
@stefanprodan
Copy link
Member

Major breaking change shipped on a Friday 😱 This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

@stefanprodan stefanprodan changed the title Quay.io: error requested limit 1000 is too high, max is 100 Quay.io: TOO_MANY_TAGS_REQUESTED requested limit 1000 is too high, max is 100 Jun 21, 2024
@YoninL
Copy link

YoninL commented Jun 21, 2024

This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

This is also quay.io images limited, right? Not others.

@makkes
Copy link
Member

makkes commented Jun 21, 2024

This also breaks source-controller for HelmCharts and OCIRepositories with semver ranges.

This is also quay.io images limited, right? Not others.

yes

@stefanprodan
Copy link
Member

In order to resume using Image Automation with Quay.io, we'd need some way of setting pageSize on the ImageRepository.

This shouldn't be needed. Quay should return a page with 100 tags (their max page size) along with a link header for the next page. This is how all the other registries behave.

@joedborg
Copy link

Is there any way (except recompiling IRC) to get the maximum to 100 in the interim?

@makkes
Copy link
Member

makkes commented Jun 21, 2024

@makkes
Copy link
Member

makkes commented Jun 21, 2024

Is there any way (except recompiling IRC) to get the maximum to 100 in the interim?

No, the default limit parameter is hard-coded to 1000 and current IRC has no way to change that.

@syed
Copy link

syed commented Jun 21, 2024

We (quay.io) have deployed a fix where you'll get the max tags instead of a 417. Sorry for the Friday disruption 😅

@stefanprodan
Copy link
Member

Thanks @syed

Due to exponential backoff in Flux, the ImageRepository reconcilers will take a long time to recover. For a faster recovery, restar image-reflector-controller by deleting its pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants