Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image update automation is not scoped to path in repo #4217

Closed
1 task done
avielb opened this issue Sep 5, 2023 · 1 comment
Closed
1 task done

image update automation is not scoped to path in repo #4217

avielb opened this issue Sep 5, 2023 · 1 comment

Comments

@avielb
Copy link

avielb commented Sep 5, 2023

Describe the bug

I've deployed flux to two kubernetes clusters and configured it using the bootstrap command to specific path for each cluster in the same git repository

the clusters deployed with the same definitions of image policy and image update automation.
what occurs when I change one of the image policies on one of the clusters to a different tag regex it will cause the image update automation to commit the change on both of the helmreleases on the clusters

my guess that this is happening because the image update automation has this spec:

  git:
    checkout:
      ref:
        branch: master
    commit:
      author:
        email: [email protected]
        name: FluxBot
  interval: 1m
  sourceRef:
    kind: GitRepository
    name: flux-system
    namespace: flux-system
  update:
    strategy: Setters

and no option to specify in it's CRD also the path in the repo aside from the branch

Steps to reproduce

  1. deploy two clusters of kubernetes
  2. run the bootstrap command on two clusters, with different --path argument for each one
  3. set in the repository a helmrelease with image policy and image automation resources to update the image for both clusters
  4. change the image tag regex for the image policy on one cluster and see that the image update automation will set the image tag for both clusters

Expected behavior

the image update automation resource be scoped to the path in the repo.

Screenshots and recordings

No response

OS / Distro

linux

Flux version

v2.1.0

Flux check

► checking prerequisites
✔ Kubernetes 1.26.7-eks-2d98532 >=1.25.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.36.0
✔ image-automation-controller: deployment ready
► ghcr.io/fluxcd/image-automation-controller:v0.36.0
✔ image-reflector-controller: deployment ready
► ghcr.io/fluxcd/image-reflector-controller:v0.30.0
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v1.1.0
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v1.1.0
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v1.1.0
► checking crds
✔ alerts.notification.toolkit.fluxcd.io/v1beta2
✔ buckets.source.toolkit.fluxcd.io/v1beta2
✔ gitrepositories.source.toolkit.fluxcd.io/v1
✔ helmcharts.source.toolkit.fluxcd.io/v1beta2
✔ helmreleases.helm.toolkit.fluxcd.io/v2beta1
✔ helmrepositories.source.toolkit.fluxcd.io/v1beta2
✔ imagepolicies.image.toolkit.fluxcd.io/v1beta2
✔ imagerepositories.image.toolkit.fluxcd.io/v1beta2
✔ imageupdateautomations.image.toolkit.fluxcd.io/v1beta1
✔ kustomizations.kustomize.toolkit.fluxcd.io/v1
✔ ocirepositories.source.toolkit.fluxcd.io/v1beta2
✔ providers.notification.toolkit.fluxcd.io/v1beta2
✔ receivers.notification.toolkit.fluxcd.io/v1
✔ all checks passed

Git provider

github

Container Registry provider

artifactory

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@avielb
Copy link
Author

avielb commented Sep 5, 2023

my bad i did not find this issue before:
fluxcd/image-automation-controller#126

@avielb avielb closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant