Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unlike create secret git, flux create secret helm does not show a success message #1600

Closed
chanwit opened this issue Jul 7, 2021 · 1 comment · Fixed by #1683
Closed

unlike create secret git, flux create secret helm does not show a success message #1600

chanwit opened this issue Jul 7, 2021 · 1 comment · Fixed by #1683
Labels
good first issue Good for newcomers

Comments

@chanwit
Copy link
Contributor

chanwit commented Jul 7, 2021

While writing some test cases, I found that flux create secret helm does not show a success message, unlike create secret git.

Maybe we could improve this a bit by printing out a message like,

► secret 'helm-test' created in 'flux-system' namespace

to be consistent and also useful for testing.
@cbl315
Copy link

cbl315 commented Aug 4, 2021

/assign

@cbl315 cbl315 mentioned this issue Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: display success message while create secrets via flux cli. cbl315/flux2
3 participants
@chanwit @stefanprodan @cbl315