Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-prometheus-stack to v58 and make the gotk_resource_info help text unique #33

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

speer
Copy link
Contributor

@speer speer commented Apr 16, 2024

Make the help texts unique in kube-state-metrics customResourceState config to workaround the bug in the latest kube-state-metrics version kubernetes/kube-state-metrics#2366 (comment)

Fixes #32

@stefanprodan
Copy link
Member

Can you also update the Helm chart to the latest major version if everything works Ok please?

Bump kube-prometheus-stack to 58.x, to include kube-state-metrics v2.12.0.

Signed-off-by: Stefan Peer <[email protected]>
@kingdonb kingdonb self-assigned this Apr 16, 2024
@kingdonb
Copy link
Member

I cherry-picked the change in my flux2-monitoring-example fork and tested it out, this update indeed brings back all the kube-state-metrics on the Flux Cluster Stats dashboard 👍 thanks very much for running this down @speer

@stefanprodan stefanprodan changed the title Make help texts unique in kube-state-metrics customResourceState config Update kube-prometheus-stack to v58 and make the gotk_resource_info help text unique Apr 16, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @speer 🥇

@stefanprodan stefanprodan merged commit fbf1312 into fluxcd:main Apr 16, 2024
2 checks passed
@speer speer deleted the fix_help_texts branch April 16, 2024 20:26
jfroy added a commit to jfroy/flatops that referenced this pull request Apr 27, 2024
The configmap cleans up the main helmrelease file, and includes the
changes in fluxcd/flux2-monitoring-example#33.
jfroy added a commit to jfroy/flatops that referenced this pull request Apr 27, 2024
The configmap cleans up the main helmrelease file, and includes the
changes in fluxcd/flux2-monitoring-example#33.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gotk_resource_info metric does not work with kube-prometheus-stack > 55.x
3 participants